Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix igbinary and intl extension #75

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

JoshuaLicense
Copy link
Contributor

Description

Fix igbinary - issue with double quoting.
Fix intl - looks like this needs icu-dev to stick around.

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@JoshuaLicense JoshuaLicense self-assigned this Apr 19, 2024
@JoshuaLicense JoshuaLicense merged commit 5f13859 into main Apr 19, 2024
12 checks passed
@JoshuaLicense JoshuaLicense deleted the fix-igbinary-and-intl branch April 19, 2024 09:56
Copy link
Contributor

@rahul-dvsa rahul-dvsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local env looks good now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants